The GOOD PR Checklist
When submitting a new PR, please check for the following:
- It has no merge conflicts
- It doesn’t break other models
- It builds and runs
- It passes github tests
- Pylint settings: https://github.com/credmark/credmark-models-py/blob/main/.pylintrc
- At the command-line, run: pylint models
- It is under the maximum PR size:
- 2 files changed
- 4 models changed
- 200 lines of code changed
- For each model
- Does it pass the checklist?
- For each DTO
- Does it already exist in the Framework?
- Is it materially different from the existing DTOs